OpenZeppelin fixed this five years ago and your code still has it, why

Wed, 18 May 2022 14:00:00 +0530

Two functions

Solidity provides two encoding functions for preparing data before hashing. abi.encode pads every argument to a full 32 bytes with zero-fill. abi.encodePacked concatenates raw bytes with nothing separating adjacent arguments.

abi.encodePacked(address(0xdead), uint256(0xbeef));
abi.encodePacked(address(0xdead000000000000000000000000000000000000), uint16(0xbeef));

These two calls produce identical byte output. An address with trailing zero bytes next to a small uint packs into the exact same bytestring as a different address next to a large uint. Hash this output and use it as a signature commitment. An attacker can forge equivalent messages by shifting the type boundary between the arguments because the padding that differentiates them does not exist.

EIP-712 on truegav

OpenZeppelin fixed this five years ago and your code still has it, why

Two functions